Application of validation template applies all users - fix #21230 #21262
Conversation
SebSept
changed the title
| $("#dropdown_items_id_target{{ rand }}").val(data.items_id_target); | ||
| $("#dropdown_items_id_target{{ rand }}").trigger('change'); | ||
| } else { | ||
| $("#dropdown_items_id_target{{ rand }}").trigger('setValue', data.items_id_target); |
There was a problem hiding this comment.
I think setValue was added as an event for another reason besides just grouping .val() and .trigger('change') into a single call.
A better solution is fixing the handling of the event listener(s) for setValue in common.js or changing each call to trigger the event so the array is packed within another array or an object.
There was a problem hiding this comment.
I'm not sure that making setValue able to handle single values and also arrays is a good point.
Function able to do lots of things results in more complex code, hard to maintain. Maybe implementing a new method for array is a solution (it depends if there is more than a couple of candidates to use it).
I think this core change can be postponed.
There was a problem hiding this comment.
It isn't a separate thing. It is setting a value and triggering the change event regardless of if it is one selection or multiple. The only part of setValue handling that seems different to me is one listener that triggers an AJAX call. I haven't looked too much at it to know what it is doing exactly.
There was a problem hiding this comment.
While I agree on the general principal that fixing/improving the js core is the best general bet, I think making a change that has possible impact on all glpi is not what we should target now. I guess you should open another issue for that point, for later.
Checklist before requesting a review
Please delete options that are not relevant.
fix #21230