Skip to content

Fix selection of multiple users with validation templates #21262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

Fix selection of multiple users with validation templates #21262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,7 +1904,7 @@ function setupAdaptDropdown(config)
}
const select2_el = $('#' + field_id).select2(options);

select2_el.bind('setValue', (e, value) => {
select2_el.bind('setValue', (e, ...value) => {
$('#' + field_id).val(value).trigger('change');
});
$('label[for=' + field_id + ']').on('click', function () {
Expand Down
2 changes: 2 additions & 0 deletions templates/components/itilobject/timeline/form_validation.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@
$("#dropdown__validatortype_{{ rand }}").trigger('setValue', data.validatortype);

if (data.groups_id !== undefined && data.groups_id !== null) {
// Approver is a group or multiple users of a group
waitForElement("#dropdown_groups_id{{ rand }}").then((elm) => {
// set groups_id
$("#dropdown_groups_id{{ rand }}").ready(function() {
Expand All @@ -366,6 +367,7 @@
});
});
} else if (data.items_id_target !== undefined) {
// Approver is a single user
new Promise((resolve) => {
// if dropdown_items_id_target exists, wait for it to be removed
// is required because the dropdown is removed and recreated when the setValue is triggered
Expand Down
Loading