-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use last focused/resized view to determine shape of BqplotImageView #475
fix: use last focused/resized view to determine shape of BqplotImageView #475
Conversation
I think it's fine like this, if we also bump Line 26 in 1876875
Otherwise some people might get the old behaviour. |
We can use version 1.6.0 now (https://pypi.org/project/bqplot-image-gl/1.6.0/) |
9625a7c
to
1630099
Compare
Could you rebase to try and get the tests running? |
1630099
to
7562d4a
Compare
@dhomeier done! |
@maartenbreddels: visual failure is related to astropy/astropy#17683 / widgetti/solara#990, right? |
Indeed |
Hmm, updating to solara 1.44 seems to have broken more than it fixed – any ideas what those pytest-playwright failures are? |
The last run prior to upgrading solara already was at |
Downgrading pytest-playwright helped, but now I hit widgetti/solara#606 - which I can now reproduce (so working on that now). |
setup.cfg
Outdated
pytest-mpl | ||
solara[pytest]<1.29 | ||
pytest-ipywidgets[all] | ||
solara-ui @ https://github.com/widgetti/solara/archive/refs/heads/fix_matplotlib_backend_keyerror.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something therein is pinning jupyter-client 7.x, jupyterlab 3.x and notebook 6.x now, among others.
But for visualtest only we probably can/have to live with that for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as is, but if you want to pull the CI fixes out to further investigate the frame colour issue @maartenbreddels, fine with me, too.
As mentioned in widgetti/solara#913 pytest-ipywidgets is not compatible with newer versions of pytest-playwright. We did not notice this in solara, because we pinned playwright, which seems to limit the versions of pytest-playwright to a compatible one. If we apply the same pinning as solara, we should be able to avoid this issue.
42b4706
to
2e5310b
Compare
I've digged into why this is happening, and I think this is not a related change, and we should be able to merge this. It seems that the output we see now is correct, since I see that bqplot-image-gl gets fed the border with values |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 91 91
Lines 5271 5272 +1
=======================================
+ Hits 4534 4535 +1
Misses 737 737 ☔ View full report in Codecov by Sentry. |
@dhomeier if you agree, please rebase and merge, not squash. |
Can't see the plots now, since the Image Comparison page redirects to a nonexistent server, but sounds OK, thanks! |
Pull Request Template
Description
Instead of always using the lowest cid view to determine the aspect ratio / shape of a Bqplot image viewer, use the last focused / resized one.
focused_at
describes the time that the window of that view was last focused, whileresized_at
describes when each viewer was last resized, so this way distortion from resizing based on a view in a popout window will be fixed once the original window is brought into focus.Needs glue-viz/bqplot-image-gl#112 to work. Let me know if you need this to use the old behaviour as a fallback with previous versions of bqplot-image-gl.
TODO:
bqplot-image-gl
in the dependencies once feat: resize & focus tracking in view_data bqplot-image-gl#112 is released.