Skip to content

Conversation

@jefft0
Copy link
Contributor

@jefft0 jefft0 commented Dec 9, 2025

Resolves #2737

As required by the HID library, the executable must be built with CGO_ENABLED=1 in order to find the Ledger. We want to keep building without this flag by default so that the binary is deterministic. The HID library already has the Supported function which returns false if not built with cgo.

  • In the getLedgerDevice, if not Supported then return an error message to try building with CGO_ENABLED=1

The error message looks like:

unable to create Ledger reference in keybase, ledger support is not enabled, try building with CGO_ENABLED=1

This PR is a minimal solution as an alternative to putting CGO_ENABLED=1 in the gnokey Makefile.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Dec 9, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 9, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 9, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: jefft0/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least one of these user(s) reviewed the pull request: [jefft0 leohhhn n0izn0iz notJoon omarsy x1unix] (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/crypto/ledger/ledger_secp256k1.go 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jefft0 jefft0 marked this pull request as draft December 9, 2025 12:36
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 9, 2025
@jefft0 jefft0 force-pushed the fix/Ledger-not-found branch 2 times, most recently from 88fab13 to 531d737 Compare December 9, 2025 12:53
@jefft0 jefft0 force-pushed the fix/Ledger-not-found branch from 531d737 to 457d8c9 Compare December 9, 2025 12:53
@jefft0 jefft0 marked this pull request as ready for review December 9, 2025 13:07
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 9, 2025
@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 10, 2025
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Dec 10, 2025
@Kouteki Kouteki requested a review from aeddi December 10, 2025 16:35
@github-actions github-actions bot added the 🐹 golang Pull requests that update Go code label Dec 10, 2025
Co-authored-by: Antoine Eddi <[email protected]>
@zivkovicmilos zivkovicmilos merged commit de7d586 into gnolang:master Dec 11, 2025
108 of 111 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐹 golang Pull requests that update Go code 📦 🌐 tendermint v2 Issues or PRs tm2 related

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[gnokey] Ledger device not found

4 participants