Skip to content

fix: In getLedgerDevice() error, mention CGO_ENABLED=1 #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zivkovicmilos merged 4 commits into from
Dec 11, 2025
Merged

fix: In getLedgerDevice() error, mention CGO_ENABLED=1 #4952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
457d8c9
fix: In getLedgerDevice() error, mention CGO_ENABLED=1
jefft0 Dec 9, 2025
7a67c09
chore: In getLedgerDevice, check hid.Supported()
jefft0 Dec 10, 2025
5a6f045
Update go.mod
jefft0 Dec 10, 2025
7596060
fix error message text
jefft0 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tm2/pkg/crypto/keys/client/add_ledger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func execAddLedger(cfg *AddCfg, args []string, io commands.IO) error {
uint32(cfg.Index),
)
if err != nil {
return fmt.Errorf("unable to create Ledger reference in keybase, %w", err)
return fmt.Errorf("unable to create Ledger reference in keybase, %+w", err)
}

// Print the information
Expand Down
7 changes: 6 additions & 1 deletion tm2/pkg/crypto/ledger/ledger_secp256k1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"fmt"
"math/big"
"os"
"strings"

"github.com/btcsuite/btcd/btcec/v2"
"github.com/btcsuite/btcd/btcec/v2/ecdsa"
Expand Down Expand Up @@ -179,7 +180,11 @@ func convertDERtoBER(signatureDER []byte) ([]byte, error) {
func getLedgerDevice() (ledger.SECP256K1, error) {
device, err := ledger.Discover()
if err != nil {
return nil, errors.Wrap(err, "ledger nano S")
msg := "ledger nano S"
if strings.Contains(err.Error(), "LedgerHID device (idx 0) not found") {
msg += ". Try building with CGO_ENABLED=1"
}
return nil, errors.Wrap(err, msg)
}

return device, nil
Expand Down
Loading