Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: add max height limit and overflow for organization profile #31349

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a1012112796
Copy link
Member

as title, maybe usefull for user to jump to repository quickly when the profile READEME is too long.
example view:

屏幕截图 2024-06-13 091330

as title, maybe usefull for user to jump to repository quickly
when the profile READEME is too long

Signed-off-by: a1012112796 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2024
@a1012112796 a1012112796 added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels Jun 13, 2024
Signed-off-by: a1012112796 <[email protected]>
@foxday
Copy link

foxday commented Jun 13, 2024

Why not implement the same behaviour as Gitea user profile? Would be awesome to have the same github behaviour instead of a separate functionality.

@silverwind
Copy link
Member

silverwind commented Jun 13, 2024

How does GitHub solve it? Surely there must be a mechanism to limit overly long profile readmes on both org an user.

@axeldvera
Copy link

How does GitHub solve it? Surely there must be a way to limit overly long profile readmes on both org an user.

GitHub Adds an "Overview" tab to view the organization's readme file. There is a proposal regarding this that adds this functionality:

image

@silverwind
Copy link
Member

silverwind commented Jun 13, 2024

Tested on GitHub, there is no limit and here is a org with a 3k lines README. Tbh, I still prefer that over any nested scroll mechanisms.

@axeldvera
Copy link

Tested on GitHub, there is no limit and here is a org with a 3k lines README. Tbh, I still prefer that over any nested scroll mechanisms.

This works fine as long as the readme is viewed from a separate tab (Overview) and not at the top of the "Repositories" tab

@a1012112796
Copy link
Member Author

Tested on GitHub, there is no limit and here is a org with a 3k lines README. Tbh, I still prefer that over any nested scroll mechanisms.

This works fine as long as the readme is viewed from a separate tab (Overview) and not at the top of the "Repositories" tab

a little not like too many tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants