Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duplicating animation sprites #67533
Allow duplicating animation sprites #67533
Changes from 1 commit
d9a9936
da5819e
1f60407
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a big issue, but I wonder if it's the best to duplicate manually each property of the animation. If we add a property on SpriteFrames's animation, then this will break.
I think it would be better to modify the
SpriteFrames.animations
property directly instead, that should make it future-proof.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain deeper please, I think I didnt got it! what I got was: create a for loop and execute each action like the animation was being created manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, that's fine and it works. But if we someday add a new property to an animation, then it will break because you will be missing an action to copy the new property in the new create animation. So instead, I think you could use the
SpriteFrames.animations
property instead.It would be something like:
But if you think it's too complex your solution works too, I don't mind much, it might just be a bit less future-proof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I will approve the PR anyway, I think it's good to merge as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpriteFrames have a struct named Anim, so it's easy to duplicate everything at once. But this needs to be done in SpriteFrames, something like
duplicate_animation(animation, new_animation)
and the code(structs are passed by value, so this should be enough)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should do something about this comment. Either use
_animation_add()
here if it's possible, or add a FIXME or something.