Fix text editor stealing focus from "Find in Files" dialog on X11

[dsnopek]

Fixes #88847

Works in my testing on Fedora 40 with GNOME using xwayland.

This reverts one of the changes from PR #86441, but not all of them.

Marking as a draft for now, because I'd like to attempt to determine if the original bug that PR #86441 fixed is still fixed with the changes here. Since this doesn't revert the whole thing, it's possible that bug is still fixed, and everybody wins! However, PR #86441 didn't fix the X11 bugs that I was personally having - I made that PR on behalf of another user, so I'll need to figure out how to reproduce the original bug.

UPDATE: I confirmed that this PR doesn't re-introduce at least one of the bugs fixed by PR #86441. See this comment.

[dsnopek]

I did manage to reproduce @Mequam's original focus issue on XFCE 4 that's shown in issue #74378, when using Godot 4.3-dev2 (it was fixed by PR #86441 which was released in Godot 4.3-dev3).

However, when testing with the changes in this PR, that bug is still fixed!

There were a number of other focus bugs on a number of other window managers described on issue #74378 that folks say got fixed by PR #86441, though, so it's entirely possible that the change here is necessary to fix one of them.

That said, I think this is a good enough sign to take this PR out of draft! :-)

[dsnopek]

Looking a little deeper at the change in this PR, it's changing DisplayServerX11::window_set_ime_active(), which is probably being called by TextEdit::_notification(NOTIFICATION_FOCUS_ENTER) when the search field on the "Find in Files" dialog grabs focus.

Based on my (admittedly rough) understanding of the problems described on issue #74378, I don't think the change reverted in this PR is really needed to fix those bugs.

Those bugs seem to center around Godot grabbing focus due to window-related events. However, the window_set_ime_active() happens when text controls gain focus. And, so, maybe we don't need the "protections" added in PR #86441 in this case?

Anyway, the only way to really know for sure is for this change to get lots more testing :-)

[akien-mga]

Tested on Fedora 40, with KDE Plasma, both Wayland (XWayland) and X11 flavors of it.

On both, I can reproduce the bug in master, and this PR fixes it.

The bug isn't reproducible with the Wayland DisplayDriver, but it doesn't support multiple windows so that's expected.

[akien-mga]

Thanks!

[pancelor]

This fixed the issue for me -- Manjaro / KDE Plasma 6 / X11 -- thank you!

(full system info: Godot v4.3.beta (811ce36c6) - Manjaro Linux #1 SMP PREEMPT_DYNAMIC Mon May 27 03:41:25 UTC 2024 - X11 - GLES3 (Compatibility) - AMD Radeon RX 6600 (radeonsi, navi23, LLVM 17.0.6, DRM 3.54, 6.6.32-1-MANJARO) - AMD FX(tm)-8350 Eight-Core Processor (8 Threads))