chore: implement dynamic versioning and rename package to a2ui-agent-sdk#1046
chore: implement dynamic versioning and rename package to a2ui-agent-sdk#1046nan-yu merged 2 commits intogoogle:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the Python agent package to a2ui-agent-sdk and implements dynamic versioning using hatchling, moving the version definition to a new version.py file. The review identifies a missing version in uv.lock that impacts build reproducibility and suggests aligning the distribution name with the import package name to prevent user confusion. Additionally, the feedback recommends defining __all__ in __init__.py and notes that tests must be included for these changes to adhere to the repository's style guide.
| name = "a2ui-agent" | ||
| version = "0.1.0" | ||
| description = "A2UI Agent" | ||
| name = "a2ui-agent-sdk" |
There was a problem hiding this comment.
The distribution name (a2ui-agent-sdk) and the package import name (a2ui) are inconsistent. This can lead to confusion for users (e.g., pip install a2ui-agent-sdk but import a2ui) and potential namespace conflicts if other a2ui components are developed. Consider renaming the package directory to a2ui_agent_sdk or ensuring a2ui is implemented as a proper namespace package.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from .version import __version__ |
There was a problem hiding this comment.
It is recommended to define __all__ when exporting symbols from __init__.py. This explicitly defines the public API of the package and helps with linting and auto-import tools.
| from .version import __version__ | |
| from .version import __version__ | |
| __all__ = ["__version__"] |
| # Switch to VCS-based versioning which derives version | ||
| # from Git tags automatically with the hatch-vcs plugin | ||
| # when we start using Git tags. | ||
| __version__ = "0.1.2" |
There was a problem hiding this comment.
According to the repository style guide, code changes should include tests. Please ensure there are tests verifying the versioning (e.g., checking that a2ui.__version__ matches the expected value) and the package renaming.
References
- If there are code changes, code should have tests. (link)
…l sample projects
2 participants
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.