-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: implement dynamic versioning and rename package to a2ui-agent-sdk #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,4 +10,5 @@ | |
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| from .version import __version__ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # File-based dynamic versioning | ||
| # - The next release version | ||
| # - Version format: major.minor.patch | ||
| # - Update the version in this file before releasing | ||
| # | ||
| # TODO: | ||
| # Switch to VCS-based versioning which derives version | ||
| # from Git tags automatically with the hatch-vcs plugin | ||
| # when we start using Git tags. | ||
| __version__ = "0.1.2" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the repository style guide, code changes should include tests. Please ensure there are tests verifying the versioning (e.g., checking that References
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distribution name (
a2ui-agent-sdk) and the package import name (a2ui) are inconsistent. This can lead to confusion for users (e.g.,pip install a2ui-agent-sdkbutimport a2ui) and potential namespace conflicts if othera2uicomponents are developed. Consider renaming the package directory toa2ui_agent_sdkor ensuringa2uiis implemented as a proper namespace package.