fix(angular): unify preact signals instance and make tests headless#982
Merged
ava-cassiopeia merged 6 commits intogoogle:mainfrom Mar 25, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ava-cassiopeia
requested changes
Mar 25, 2026
The MessageProcessor now relies on a 'version' signal used to trigger change detection for in-place data mutations, thus requiring the 'version' property to also be mocked in tests. This fix resolves failing tests in surface.spec.ts, row-integration.spec.ts, and v0_8_integration.spec.ts.
gspencergoog
force-pushed
the
fix/angular-preact-unify
branch
from
3ed1ad7 to
1d1ee6a
Compare
ava-cassiopeia
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the export of signals so it comes from
web_coreinstead ofpreact, because it caused duplicate definitions and tests were failing. Not sure why that wasn't caught in CI...Also switched the
a2ui_explorerexample tests to use Jasmine instead of vitest, since the other tests are Jasmine tests, for consistency.Made the tests run headless, since there's no value in seeing them run (and it steals focus if you're trying to work, and doesn't work over ssh).