Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { A2uiRendererService } from '@a2ui/angular/v0_9';
import { ActionDispatcher } from './action-dispatcher.service';
import { Subject } from 'rxjs';
import { A2uiMessage } from '@a2ui/web_core/v0_9';
import { vi, describe, it, expect, beforeEach } from 'vitest';

describe('AgentStubService', () => {
let service: AgentStubService;
Expand All @@ -30,10 +29,10 @@ describe('AgentStubService', () => {

beforeEach(() => {
mockSurfaceGroup = {
getSurface: vi.fn(),
getSurface: jasmine.createSpy('getSurface'),
};
mockRendererService = {
processMessages: vi.fn(),
processMessages: jasmine.createSpy('processMessages'),
get surfaceGroup() {
return mockSurfaceGroup;
},
Expand Down Expand Up @@ -69,28 +68,28 @@ describe('AgentStubService', () => {
const messages = [createMsg];

// 1. First call: Surface does not exist
mockSurfaceGroup.getSurface.mockReturnValue(undefined);
mockSurfaceGroup.getSurface.and.returnValue(undefined);
service.initializeDemo(messages);

// Should have called processMessages with initial messages only
expect(mockRendererService.processMessages).toHaveBeenCalledWith(messages);
expect(mockRendererService.processMessages).toHaveBeenCalledTimes(1);
mockRendererService.processMessages.mockClear();
mockRendererService.processMessages.calls.reset();

// 2. Second call: Surface now exists
mockSurfaceGroup.getSurface.mockReturnValue({ id: surfaceId });
mockSurfaceGroup.getSurface.and.returnValue({ id: surfaceId });
service.initializeDemo(messages);

// Should have called processMessages twice:
// First with deleteSurface, then with initial messages
expect(mockRendererService.processMessages).toHaveBeenCalledTimes(2);
expect(mockRendererService.processMessages).toHaveBeenNthCalledWith(1, [
expect(mockRendererService.processMessages.calls.argsFor(0)[0]).toEqual([
{
version: 'v0.9',
deleteSurface: { surfaceId },
},
]);
expect(mockRendererService.processMessages).toHaveBeenNthCalledWith(2, messages);
expect(mockRendererService.processMessages.calls.argsFor(1)[0]).toEqual(messages);
});

it('should NOT send deleteSurface if surface does not exist', () => {
Expand All @@ -104,7 +103,7 @@ describe('AgentStubService', () => {
};
const messages = [createMsg];

mockSurfaceGroup.getSurface.mockReturnValue(undefined);
mockSurfaceGroup.getSurface.and.returnValue(undefined);
service.initializeDemo(messages);

expect(mockRendererService.processMessages).toHaveBeenCalledTimes(1);
Expand Down
37 changes: 23 additions & 14 deletions renderers/angular/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion renderers/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"generate-examples": "node scripts/generate-examples.mjs",
"build": "npm run generate-examples && ng build && node postprocess-build.mjs",
"demo": "npm run generate-examples && ng serve a2ui_explorer",
"test": "npm run generate-examples && ng test",
"test": "npm run generate-examples && ng test --browsers=ChromeHeadless",
"test:ci": "npm run generate-examples && ng test --watch=false --browsers=ChromeHeadless"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion renderers/angular/src/v0_9/core/utils.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/

import { DestroyRef } from '@angular/core';
import { signal as preactSignal } from '@preact/signals-core';
import { toAngularSignal, getNormalizedPath } from './utils';
import { signal as preactSignal } from '@a2ui/web_core/v0_9';

describe('toAngularSignal', () => {
let mockDestroyRef: jasmine.SpyObj<DestroyRef>;
Expand Down
4 changes: 2 additions & 2 deletions renderers/web_core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion renderers/web_core/src/v0_9/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export * from './state/surface-group-model.js';
export * from './state/surface-model.js';
export * from './errors.js';

export {effect, Signal} from '@preact/signals-core';
export {effect, Signal, signal} from '@preact/signals-core';

import A2uiMessageSchemaRaw from './schemas/server_to_client.json' with {type: 'json'};

Expand Down
Loading