Add Markdown support to basic Text widget (Lit).#998
Open
ditman wants to merge 7 commits intogoogle:mainfrom
Open
Add Markdown support to basic Text widget (Lit).#998ditman wants to merge 7 commits intogoogle:mainfrom
ditman wants to merge 7 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Lit renderer to version 0.8.5, introducing markdown support for the Text widget and a new Context.markdown API for dependency injection. It adds a MarkdownDirective that utilizes unsafeHTML and until for asynchronous rendering, along with corresponding tests and sample updates. Feedback suggests improving the logic for prepending markdown heading symbols to prevent redundant formatting when the input text already contains them.
jacobsimionato
approved these changes
Mar 27, 2026
ava-cassiopeia
approved these changes
Mar 27, 2026
Collaborator
Author
|
Should have clicked "Submit" days ago; the only change I made was to sync the changelog with the newest v0.9 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Markdown support to the basic Text widget of the v0_9 Lit renderer.
(This is a very similar, but separate, implementation to what exists in v0.8 today. Adds a couple of tests to the directive.)
Also modifies the demo:gallery09 to inject a Markdown renderer for testing.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.