-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Markdown support to basic Text widget (Lit). #998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ditman
wants to merge
7
commits into
google:main
Choose a base branch
from
ditman:lit-09-markdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c927822
Bring the markdown directive from v0.8
ditman aa757ed
Make Context.markdown available to users of the package.
ditman e874a2c
Modify basic Text widget to use the Markdown renderer
ditman 5aa94f5
Modify demo:gallery09 to provide a markdown renderer.
ditman 163143e
Add missing license file.
ditman 567bba1
CHANGELOG + version
ditman a5771dc
package-lock
ditman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { markdown } from "./markdown.js"; | ||
|
|
||
| /** | ||
| * Contexts used to inject dependencies into the Lit renderer. | ||
| */ | ||
| export const Context = { | ||
| markdown, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { createContext } from "@lit/context"; | ||
| import * as Types from "@a2ui/web_core/types/types"; | ||
|
|
||
| /** | ||
| * The markdown renderer context. | ||
| * | ||
| * This is used by the Text widget to render markdown content. | ||
| */ | ||
| export const markdown = createContext<Types.MarkdownRenderer | undefined>(Symbol("A2UIMarkdown")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| export { markdown } from "./markdown.js"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { html, noChange } from "lit"; | ||
| import { | ||
| Directive, | ||
| DirectiveParameters, | ||
| Part, | ||
| directive, | ||
| } from "lit/directive.js"; | ||
| import { unsafeHTML } from "lit/directives/unsafe-html.js"; | ||
| import { until } from "lit/directives/until.js"; | ||
| import * as Types from "@a2ui/web_core/types/types"; | ||
|
|
||
| class MarkdownDirective extends Directive { | ||
| private lastValue: string | null = null; | ||
| private lastTagClassMap: string | null = null; | ||
|
|
||
| update(_part: Part, [value, markdownRenderer, markdownOptions]: DirectiveParameters<this>) { | ||
| const jsonTagClassMap = JSON.stringify(markdownOptions?.tagClassMap); | ||
| if ( | ||
| this.lastValue === value && | ||
| jsonTagClassMap === this.lastTagClassMap | ||
| ) { | ||
| return noChange; | ||
| } | ||
|
|
||
| this.lastValue = value; | ||
| this.lastTagClassMap = jsonTagClassMap; | ||
| return this.render(value, markdownRenderer, markdownOptions); | ||
| } | ||
|
|
||
| private static defaultMarkdownWarningLogged = false; | ||
| /** | ||
| * Renders the markdown string to HTML using the injected markdown renderer, | ||
| * if present. Otherwise, it returns the value wrapped in a span. | ||
| */ | ||
| render(value: string, markdownRenderer?: Types.MarkdownRenderer, markdownOptions?: Types.MarkdownRendererOptions) { | ||
| if (markdownRenderer) { | ||
| const rendered = markdownRenderer(value, markdownOptions).then((value) => { | ||
| // `value` is a plain string, which we need to convert to a template | ||
| // with the `unsafeHTML` directive. | ||
| // It is the responsibility of the markdown renderer to sanitize the HTML. | ||
| return unsafeHTML(value); | ||
| }) | ||
| // The until directive lets us render a placeholder *until* the rendered | ||
| // content resolves. | ||
| return until(rendered, html`<span class="no-markdown-renderer">${value}</span>`); | ||
| } | ||
|
|
||
| if (!MarkdownDirective.defaultMarkdownWarningLogged) { | ||
| console.warn("[MarkdownDirective]", | ||
| "can't render markdown because no markdown renderer is configured.\n", | ||
| "Use `@a2ui/markdown-it`, or your own markdown renderer."); | ||
| MarkdownDirective.defaultMarkdownWarningLogged = true; | ||
| } | ||
| return html`<span class="no-markdown-renderer">${value}</span>`; | ||
| } | ||
| } | ||
|
|
||
| export const markdown = directive(MarkdownDirective); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { setupTestDom, teardownTestDom, asyncUpdate } from "./dom-setup.js"; | ||
| import assert from "node:assert"; | ||
| import { describe, it, before, after } from "node:test"; | ||
| import * as Types from "@a2ui/web_core/types/types"; | ||
|
|
||
| describe("Markdown Directive", () => { | ||
| before(() => { | ||
| // Set up the DOM before any lit imports in the tests | ||
| setupTestDom(); | ||
| }); | ||
|
|
||
| after(() => { | ||
| teardownTestDom(); | ||
| }); | ||
|
|
||
| it("should render fallback when no renderer is provided", async () => { | ||
| const { html, render } = await import("lit"); | ||
| const { markdown } = await import("../directives/markdown.js"); | ||
|
|
||
| const container = document.createElement("div"); | ||
|
|
||
| // Render the directive directly into our container | ||
| render(html`<div>${markdown("Hello world")}</div>`, container); | ||
|
|
||
| const htmlContent = container.innerHTML; | ||
| assert.ok( | ||
| htmlContent.includes("no-markdown-renderer"), | ||
| "Should render fallback span class", | ||
| ); | ||
| assert.ok( | ||
| container.textContent?.includes("Hello world"), | ||
| "Should render fallback text properly", | ||
| ); | ||
| }); | ||
|
|
||
| it("should render parsed markdown when renderer is provided", async () => { | ||
| const { html, render } = await import("lit"); | ||
| const { markdown } = await import("../directives/markdown.js"); | ||
|
|
||
| const container = document.createElement("div"); | ||
|
|
||
| let resolveRenderer: (value: string) => void; | ||
| // Leak the `resolve` function of this promise to the `resolveRenderer` | ||
| // variable, so we can call it later in the test. | ||
| const renderPromise = new Promise<string>((resolve) => { | ||
| resolveRenderer = resolve; | ||
| }); | ||
| // Mock a markdown renderer that resolves by calling `resolveRenderer` | ||
| const mockRenderer: Types.MarkdownRenderer = async () => renderPromise; | ||
|
|
||
| // Render the directive with our mock renderer | ||
| render( | ||
| html`<div>${markdown("Hello markdown", mockRenderer)}</div>`, | ||
| container, | ||
| ); | ||
|
|
||
| // Before resolution, should show the placeholder (until directive) | ||
| assert.ok(container.innerHTML.includes("no-markdown-renderer")); | ||
|
|
||
| // Resolve the promise via asyncUpdate so it yields to the macro-task queue | ||
| await asyncUpdate(container, () => { | ||
| resolveRenderer!("<b>Rendered HTML</b>"); | ||
| }); | ||
|
|
||
| const htmlContent = container.innerHTML; | ||
| assert.ok( | ||
| htmlContent.includes("<b>Rendered HTML</b>"), | ||
| "Should render the HTML from the renderer", | ||
| ); | ||
| assert.ok( | ||
| !htmlContent.includes("no-markdown-renderer"), | ||
| "Placeholder should be gone", | ||
| ); | ||
| }); | ||
| }); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.