R151 redux #4192
Merged
R151 redux #4192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... didn't this piece of code warn you? Or was the fact the fact that the boolean got inverted that confused you? /cc @donmccurdy |
|
Oh... Maybe because of the types? |
|
It'd be preferable if the type definitions did something like this, though I imagine it's more trouble to maintain: /**
* @deprecated Replaced by .useLegacyLights in r151+
* @default false
*/
physicallyCorrectLights: boolean;
/** @default true */
useLegacyLights: boolean; |
|
Yeah, I was just going too fast. I had assumed anything called "useLegacy" would default to false. |
|
One day... 😢 |
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* updated to three.js r151 * r151.2 * updated goldens * DO NOT USE LEGACY LIGHTS * fix two goldens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-landing #4186
Apparently we have to specify that legacy lighting is a bad idea in PBR...