Skip to content

Conversation

@Yuan325
Copy link
Contributor

@Yuan325 Yuan325 commented Jan 8, 2026

Move source-related queries from Invoke() function into Source.

This is an effort to generalizing tools to work with any Source that implements a specific interface. This will provide a better segregation of the roles for Tools vs Source.

Tool's role will be limited to the following:

  • Resolve any pre-implementation steps or parameters (e.g. template parameters)
  • Retrieving Source
  • Calling the source's implementation

@Yuan325 Yuan325 requested a review from a team as a code owner January 8, 2026 06:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the MongoDB integration by centralizing all database interaction logic within the Source implementation. This change aims to establish a clearer separation of responsibilities, where individual tools are primarily concerned with parameter resolution and invoking the appropriate Source method, rather than directly handling MongoDB queries and data processing. This architectural improvement enhances modularity and prepares the system for more generalized source interactions.

Highlights

  • Refactored MongoDB Source Implementation: Moved all MongoDB query and data manipulation logic from individual tool Invoke() functions into new methods on the Source struct within internal/sources/mongodb/mongodb.go.
  • Centralized Database Operations: Introduced dedicated methods on the Source struct, such as Aggregate, Find, FindOne, InsertMany, InsertOne, UpdateMany, UpdateOne, DeleteMany, and DeleteOne, to encapsulate all MongoDB interactions.
  • Simplified Tool Invoke() Functions: The Invoke() functions in various MongoDB tools (e.g., mongodbaggregate, mongodbfind) have been significantly simplified to delegate directly to the corresponding new Source methods, reducing their complexity and improving readability.
  • Updated Interfaces and Dependencies: The compatibleSource interfaces in each tool have been updated to reflect the new methods available on the Source. Additionally, direct bson and json imports were removed from tool files, as data marshalling/unmarshalling is now handled internally by the Source.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors the MongoDB tools by centralizing the database interaction logic within the mongodb.Source type. This is a solid architectural improvement that enhances separation of concerns and will make the tools more generic and maintainable. The changes across the various tool packages are clean and consistent with the refactoring goal. My review focuses on the new implementation in mongodb.go and includes suggestions to improve error handling, code clarity, and behavioral consistency, particularly around BSON/JSON conversions and delete operations. Overall, this is a valuable refactoring, and addressing the feedback will further strengthen the implementation.

@Yuan325 Yuan325 force-pushed the source-implementation-mongodb branch from 0386d6b to 34d7df7 Compare January 8, 2026 07:45
@Yuan325 Yuan325 merged commit 5dbf207 into main Jan 12, 2026
12 checks passed
@Yuan325 Yuan325 deleted the source-implementation-mongodb branch January 12, 2026 23:25
vinodhinic pushed a commit to vinodhinic/genai-toolbox that referenced this pull request Jan 14, 2026
…ction into Source (googleapis#2277)

Move source-related queries from `Invoke()` function into Source.

This is an effort to generalizing tools to work with any Source that
implements a specific interface. This will provide a better segregation
of the roles for Tools vs Source.

Tool's role will be limited to the following:
* Resolve any pre-implementation steps or parameters (e.g. template
parameters)
* Retrieving Source
* Calling the source's implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants