Added class for close button image#8
Conversation
Added option to add close image class. option name is 'closeClass' This can be used to apply css class to close image. I have added this because recently i encountered problem where I want to apply some css rules to close button and there was no easiest way as per the script to achieve that. Now we can apply css class and apply css rules as we wish.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
src/infobubble.js
Outdated
There was a problem hiding this comment.
Why did you remove this line?
There was a problem hiding this comment.
Sorry, I had an issue with varied height content. If I set MaxHeight, for example, 400px, It applies it as css height:400px, which is not ideal. It means even if content is shorter, it will make infoBubble longer. If content is longer than it adds scrollbar. Both of them are not acceptable. So, I just removed the height thing from my script.
It may not be the issue for others, You can ignore that particular line change.
There was a problem hiding this comment.
I can't just ignore the line change unfortunately. <yoda>Merge or do not merge, there is no ignore. </yoda>
If you remove this change I'll merge it in.
For this merge request, I am just removing comment // for line no 1762, which I have done for my personal changes. Its back now as it is with changes I have done to add css class for close button.
|
Updated it. |
src/infobubble.js
Outdated
Updated className string in line 799, 801, 802 and 803
4 participants
Added option to add close image css class.
option name is 'closeClass'
This can be used to apply css class to close image.
I have added this because recently I encountered problem where I want to apply some css rules to close button and there was no easiest way as per the script to achieve that. Now we can apply css class and css rules as we wish using this.