Removed reflector metric usage

[vicentefb]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:
Closes #3540

Special notes for your reviewer:

[agones-bot]

Build Succeeded 🥳

Build Id: 16a19f7e-22f1-4611-8795-2b26d98e49e5

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-a9910c9
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-a9910c9
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-a9910c9-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-a9910c9
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-a9910c9
• Linux C++ SDK (build): agonessdk-1.46.0-dev-a9910c9-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.46.0-dev-a9910c9.zip

A preview of the website (the last 30 builds are retained):

• https://a9910c9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4056/head:pr_4056 && git checkout pr_4056
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-a9910c9

[0xaravindh]

@vicentefb

We have to remove docs as well.

agones/site/content/en/docs/Guides/metrics.md

Lines 71 to 75 in def4351

	| agones_k8s_client_cache_list_total | The total number of list operations for client-go caches | counter |
	| agones_k8s_client_cache_list_duration_seconds | Duration of a Kubernetes list API call in seconds | histogram |
	| agones_k8s_client_cache_list_items | Count of items in a list from the Kubernetes API | histogram |
	| agones_k8s_client_cache_watches_total | The total number of watch operations for client-go caches | counter |
	| agones_k8s_client_cache_last_resource_version | Last resource version from the Kubernetes API | gauge |

agones/site/content/en/docs/Guides/metrics.md

Line 113 in def4351

- {{< ghlink href="/build/grafana/dashboard-goclient-caches.yaml" branch="main" >}}Agones Controller go-client caches{{< /ghlink >}} displays Agones Controller Kubernetes Watches/Lists operations used.

[agones-bot]

Build Failed 😭

Build Id: e5173ba4-85fb-4d78-ae8b-c3bb68f0db0d

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😭

Build Id: efc8fc6f-0007-4780-a209-6ef6a2ac8e64

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 🥳

Build Id: b4f8ac77-2b57-4d59-b429-f63d06c4ad10

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-8e63db8
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-8e63db8
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-8e63db8-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-8e63db8
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-8e63db8
• Linux C++ SDK (build): agonessdk-1.46.0-dev-8e63db8-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.46.0-dev-8e63db8.zip

A preview of the website (the last 30 builds are retained):

• https://8e63db8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4056/head:pr_4056 && git checkout pr_4056
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-8e63db8

[vicentefb]

Missing to test locally

[0xaravindh]

LGTM

[gongmax]

Did you test locally to ensure nothing is broken?

[vicentefb]

Oops not yet, i just meant to update the branch not merge it !

[agones-bot]

Build Failed 😭

Build Id: d172f73b-57d0-4dc7-9db1-c12548709808

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[vicentefb]

Yes these changes are working as expected and the dashboard looks good.

[igooch]

/gcbrun

[agones-bot]

Build Succeeded 🥳

Build Id: 04424d2a-2ea1-4136-84a0-8557dd0c5a21

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.46.0-dev-029f62f
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.46.0-dev-029f62f
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.46.0-dev-029f62f-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.46.0-dev-029f62f
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.46.0-dev-029f62f
• Linux C++ SDK (build): agonessdk-1.46.0-dev-029f62f-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.46.0-dev-029f62f.zip

A preview of the website (the last 30 builds are retained):

• https://029f62f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4056/head:pr_4056 && git checkout pr_4056
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-029f62f