-
Notifications
You must be signed in to change notification settings - Fork 11
ci: vrt sharding test #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d5d0d80
vrt sharding test
noahchoii a0c1d6e
remove duplicated snapshot test
noahchoii fde72a0
fix command
noahchoii 4f19f48
rollback install-browser
noahchoii 5c91534
rollback browser channel
noahchoii 90e72a4
ubuntu -> macos
noahchoii f8246d5
merge-reports path
noahchoii 7650335
report path
noahchoii 3081202
all-blob-report path
noahchoii 1b09eb7
json reporter
noahchoii 4b1948e
edit failure condition
noahchoii 8495552
fix
noahchoii 332b7d6
add font
noahchoii b58aec7
re-test
noahchoii a8ec1fd
sharding projects
noahchoii 7b62942
fix install browser
noahchoii d3b921f
msedge
noahchoii c998f5f
object matrix
noahchoii 169f21b
add quotes
noahchoii cb10363
playwright version up
noahchoii 3124f4d
snapshot update
noahchoii 4ef5200
snapshot
noahchoii e1ff799
intuitive naming
noahchoii 953f8bd
unify naming (regressions)
noahchoii 9fbe5c5
test font blinking
noahchoii d16b274
channel
noahchoii 8053030
prevent font flickering
noahchoii e52b374
remove font
noahchoii 26b13a5
Merge branch 'main' into vrt
noahchoii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
channel속성을 제거하면 Playwright는 시스템에 설치된 Chrome이나 Edge 브라우저 대신 번들로 제공되는 Chromium 빌드를 사용하게 됩니다. 이로 인해 CI 환경과 로컬 개발 환경 간에 테스트 브라우저가 달라져 렌더링 차이가 발생할 수 있으며, 이는 시각적 회귀 테스트(VRT)의 신뢰성에 영향을 줄 수 있습니다.만약 CI 환경에서 특정 브라우저(Chrome, Edge) 설치를 피하고 일관된 테스트 환경을 구축하려는 의도라면 이 변경이 타당할 수 있습니다. 하지만, 실제 사용자가 사용하는 브라우저와 최대한 유사한 환경에서 테스트하는 것이 목적이라면
channel속성을 유지하는 것을 고려해 보세요.이 변경으로 인해 테스트가 실패하거나 예기치 않은 시각적 차이가 발생할 수 있으므로, 변경의 영향을 신중히 검토해 보시길 권장합니다.