Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @noahchoii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the continuous integration environment and Playwright test setup. The changes include optimizing a GitHub Actions composite action by removing a redundant checkout step and simplifying browser configurations within Playwright. These adjustments are likely part of an ongoing effort to enhance the efficiency and maintainability of the CI pipeline, potentially in preparation for or related to visual regression testing (VRT) sharding. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이 PR은 CI 워크플로우와 시각적 회귀 테스트(VRT) 설정을 수정합니다. .github/composite/install/action.yml에서 중복될 수 있는 checkout 단계를 제거한 것은 좋아 보입니다. 하지만 packages/core/playwright.config.ts에서 Playwright 테스트 브라우저의 channel 설정을 제거한 변경은 잠재적인 이슈가 될 수 있습니다. 이로 인해 CI와 로컬 환경 간에 사용되는 브라우저가 달라져 VRT 결과의 일관성이 깨질 수 있습니다. 해당 부분에 대해 상세한 리뷰 의견을 남겼으니 확인 후 반영을 고려해 보시기 바랍니다.
| { name: 'chromium', use: { ...devices['Desktop Chrome'] } }, | ||
| { name: 'Microsoft Edge', use: { ...devices['Desktop Edge'] } }, |
There was a problem hiding this comment.
channel 속성을 제거하면 Playwright는 시스템에 설치된 Chrome이나 Edge 브라우저 대신 번들로 제공되는 Chromium 빌드를 사용하게 됩니다. 이로 인해 CI 환경과 로컬 개발 환경 간에 테스트 브라우저가 달라져 렌더링 차이가 발생할 수 있으며, 이는 시각적 회귀 테스트(VRT)의 신뢰성에 영향을 줄 수 있습니다.
만약 CI 환경에서 특정 브라우저(Chrome, Edge) 설치를 피하고 일관된 테스트 환경을 구축하려는 의도라면 이 변경이 타당할 수 있습니다. 하지만, 실제 사용자가 사용하는 브라우저와 최대한 유사한 환경에서 테스트하는 것이 목적이라면 channel 속성을 유지하는 것을 고려해 보세요.
이 변경으로 인해 테스트가 실패하거나 예기치 않은 시각적 차이가 발생할 수 있으므로, 변경의 영향을 신중히 검토해 보시길 권장합니다.
{
name: 'chromium',
use: { ...devices['Desktop Chrome'], channel: 'chrome' },
},
{
name: 'Microsoft Edge',
use: { ...devices['Desktop Edge'], channel: 'msedge' },
},
|
✅ All tests passed!
Click here if you need to update snapshots. |
noahchoii
added
type: enhancement
ZeroChoi2781
left a comment
ZeroChoi2781
left a comment
There was a problem hiding this comment.
[Nit]
In the long term, it's ideal to include fonts in Storybook as well, just like in the actual rendering environment. This prevents situations where a component's layout subtly changes or breaks depending on the font style.
However, preventing test failures right now is more important. We can revisit this issue later once things stabilize and find a solution. Great work : )
4 participants
Description of Changes
strategy.matrixfeature.Checklist
Before submitting the PR, please make sure you have checked all of the following items.