SL-11155 : Fix redirect check in Float.Core #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 files 2 suites 2s ⏱️ Results for commit 83a2854. ♻️ This comment has been updated with latest results. |
mediabounds
requested changes
May 27, 2025
Member
mediabounds
left a comment
mediabounds
left a comment
There was a problem hiding this comment.
In addition to addressing the in-line note, can you also...
- Modify
.github/workflows/test.ymlto include8.0.xin the dotnet versions - Modify
.github/workflows/deploy.ymlto include8.0.xin the dotnet versions
Float.Core/Net/RequestClient.cs
Outdated
| // Verify if a redirect happened. | ||
| if (httpResponse.StatusCode == HttpStatusCode.Moved | ||
| || httpResponse.StatusCode == HttpStatusCode.MovedPermanently) | ||
| || httpResponse.StatusCode == HttpStatusCode.MovedPermanently |
Member
There was a problem hiding this comment.
According to the docs, MovedPermanently is a synonym for Moved.
Suggested change
| || httpResponse.StatusCode == HttpStatusCode.MovedPermanently |
mediabounds
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled 302 (Found) redirect in RequestClient