Skip to content

SL-11155 : Fix redirect check in Float.Core #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

SL-11155 : Fix redirect check in Float.Core #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93697f9
Handled 302 (Found) redirect in RequestClient
May 26, 2025
409e5a0
Removed redundant MovedPermanently check and added 8.0.x to the YAML …
May 28, 2025
aef26e7
Dropping support for .NET 3.1
mediabounds May 28, 2025
83a2854
Only support .NET 7 and 8
mediabounds May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
uses: actions/setup-dotnet@v3
with:
dotnet-version: |
3.1.x
6.0.x
7.0.x
8.0.x
- name: Retore Workload
run: dotnet workload restore
- name: Restore dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
uses: actions/setup-dotnet@v3
with:
dotnet-version: |
3.1.x
6.0.x
7.0.x
8.0.x
- name: Retore Workload
run: dotnet workload restore
- name: Restore dependencies
Expand Down
2 changes: 1 addition & 1 deletion Float.Core.Tests/Float.Core.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netcoreapp3.1;net7.0;net8.0;</TargetFrameworks>
<TargetFrameworks>net7.0;net8.0;</TargetFrameworks>
<IsPackable>false</IsPackable>
<LangVersion>9.0</LangVersion>
<UseMaui>true</UseMaui>
Expand Down
2 changes: 1 addition & 1 deletion Float.Core/Float.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>netstandard2;net7.0;net8.0;</TargetFrameworks>
<TargetFrameworks>net7.0;net8.0;</TargetFrameworks>
<AssemblyName>Float.Core</AssemblyName>
<AssemblyAuthor>Float</AssemblyAuthor>
<AssemblyDescription>Common utility code used by Float projects.</AssemblyDescription>
Expand Down
2 changes: 1 addition & 1 deletion Float.Core/Net/RequestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ async Task<Response> Send(HttpRequestMessage request)

// Verify if a redirect happened.
if (httpResponse.StatusCode == HttpStatusCode.Moved
|| httpResponse.StatusCode == HttpStatusCode.MovedPermanently)
|| httpResponse.StatusCode == HttpStatusCode.Found)
{
var redirectUrl = httpResponse.Headers.Location;

Expand Down
Loading