Skip to content

Conversation

@kalleep
Copy link
Contributor

@kalleep kalleep commented Oct 3, 2025

To prepare to use go 1.25.1 for alloy

@kalleep kalleep requested a review from a team as a code owner October 3, 2025 13:49
Copy link
Contributor

@jharvey10 jharvey10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the windows build image as well?

over at:

tools/build-image/windows/Dockerfile

Looks like it's lagging behind at the moment at 1.24.0

Edit: Actually I'm not sure I understand how (if at all) windows build images are used. I see that dockerfile is used for testing a windows build image, but I wasn't finding any publication of a windows build image. 🤷‍♂️

@kalleep
Copy link
Contributor Author

kalleep commented Oct 9, 2025

Should we do the windows build image as well?

over at:

tools/build-image/windows/Dockerfile

Looks like it's lagging behind at the moment at 1.24.0

Edit: Actually I'm not sure I understand how (if at all) windows build images are used. I see that dockerfile is used for testing a windows build image, but I wasn't finding any publication of a windows build image. 🤷‍♂️

Well windows build image is currently not used at all, but we should bring it back. At the moment everything from that images is included in Dockerfile.windows https://github.com/grafana/alloy/blob/main/Dockerfile.windows#L10-L19. This happened when we migrated to GHA but we should bring it back. Building windows release images takes 1 hour in our ci atm...

@jharvey10
Copy link
Contributor

jharvey10 commented Oct 9, 2025

👍 Okay, I created issue #4584 for that and I'll mark this one as approved in the meantime.

@kalleep kalleep merged commit 3037314 into main Oct 20, 2025
46 of 47 checks passed
@kalleep kalleep deleted the update-go-1-25-1-build-image branch October 20, 2025 07:21
@kalleep kalleep mentioned this pull request Oct 22, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants