Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promql: Update error message when using disabled PromQL experimental aggregation function #788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zenador
Copy link
Contributor

@zenador zenador commented Dec 9, 2024

For these reasons:

  1. The previous message hardcoded the names of the PromQL experimental functions that were aggregators, the new message does not hardcode and does not need to be updated along with any changes in the experimental aggregation functions
  2. The new message specifies the function used instead of a generic message
  3. The new message is more consistent with the error message given when the user tries to use a disabled PromQL experimental function that is not an aggregator

We are modifying only the fork since we want to have a different message from the original that does not mention the config flag that may not apply to Mimir. This new message is also more consistent with the original in that it specifies the function used instead of a generic message with the hardcoded names.

Follow up to https://github.com/grafana/mimir-squad/issues/2586

@zenador zenador requested a review from aknuds1 December 9, 2024 11:55
@zenador zenador force-pushed the zenador/update-err-msg-promql-exp-agg branch from 07d9305 to 5764601 Compare December 9, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant