Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP: Cost attribution #10269
base: main
Are you sure you want to change the base?
MVP: Cost attribution #10269
Changes from 2 commits
e315ebb
f04c28f
2c422d1
d2eab6b
1f39282
9b4337d
1a523e1
f10f787
cc0e939
c020be0
71e4666
9dd101b
7d4ea9a
6754666
fffc5b3
2cf8c3e
f994034
b060c09
e35a8d9
5cc0b5d
389dff0
116a69e
9c30445
88ef49e
130636a
b701ba7
dccd9c8
eebd028
8386503
d8f1e9b
b9efb94
a37e6de
211b3a2
f697e6f
fe8a1e5
8b5836f
888d8b0
b15b487
87209d6
4706bde
1ab1f00
8111b6c
17b64a9
a191044
2bb1845
ddd507d
b27e379
a79fac7
37901b7
f7115f4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this doesn't need to be exported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this logic seems to belong to
Tracker
. Please create a method there that would do it, and would just tell us whether we need to remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 7d4ea9a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does much more than it says, can we extract a common "
updateTracker(userID) *Tracker
, make it responsible for updating (or deleting! like in the for loop above), and returning the proper*Tracker
for a user?Then in the for loop above we can just do something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in commit 9dd101b