Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: expose log level through log wrappers #10604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Feb 7, 2025

What this PR does

Logging: expose log level through log wrappers

So that Debug() calls are fast when debug logging is disabled.

Which issue(s) this PR fixes or relates to

prometheus/prometheus#15993

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Checking the difference between Info and Debug logs.

Signed-off-by: Bryan Boreham <[email protected]>
So that Debug() calls are fast when debug logging is disabled.

Signed-off-by: Bryan Boreham <[email protected]>
@bboreham bboreham requested a review from a team as a code owner February 7, 2025 18:16
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier than rewriting to slog

@dimitarvdimitrov dimitarvdimitrov changed the title Wrap level Logging: expose log level through log wrappers Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants