-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Graphiql to fix layout #1131
base: master
Are you sure you want to change the base?
Conversation
@@ -52,8 +52,7 @@ | |||
--> | |||
<link | |||
rel="stylesheet" | |||
href="https://unpkg.com/[email protected]/graphiql.min.css" | |||
integrity="sha384-1YHEU+Xy8hlKYAZ26WTz+JQEPMM6i/Mx5m8umMkSZChlzSYmq7RqyCyRbGqrILVZ" | |||
href="https://unpkg.com/graphiql/graphiql.min.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should maintain a specific version tag and integrity hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, updated
@@ -52,8 +52,7 @@ | |||
--> | |||
<link | |||
rel="stylesheet" | |||
href="https://unpkg.com/[email protected]/graphiql.min.css" | |||
integrity="sha384-1YHEU+Xy8hlKYAZ26WTz+JQEPMM6i/Mx5m8umMkSZChlzSYmq7RqyCyRbGqrILVZ" | |||
href="https://unpkg.com/graphiql/graphiql.min.css" | |||
crossorigin="anonymous" | |||
/> | |||
<script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the next line there is a reference to graphiqlWithExtensions. Is this old version compatible with the new version of GraphiQL ? All other features still work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ive checked and it works as expected
Fix for issue #1129