Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Graphiql to fix layout #1131

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Bump Graphiql to fix layout #1131

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62fad1c
bump graphiql to fix layout
May 4, 2024
c88c755
next upd
May 6, 2024
2524736
remove due to useless
May 22, 2024
aafc27c
Merge branch 'develop' into master
Shane32 Aug 3, 2024
dfbebbe
Update migration8.md
Shane32 Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Ui.GraphiQL/Internal/graphiql.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
* Copyright (c) 2021 GraphQL Contributors
* Copyright (c) 2024 GraphQL Contributors
* All rights reserved.
*
* This source code is licensed under the license found in the
Expand Down Expand Up @@ -52,8 +52,7 @@
-->
<link
rel="stylesheet"
href="https://unpkg.com/[email protected]/graphiql.min.css"
integrity="sha384-1YHEU+Xy8hlKYAZ26WTz+JQEPMM6i/Mx5m8umMkSZChlzSYmq7RqyCyRbGqrILVZ"
href="https://unpkg.com/graphiql/graphiql.min.css"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should maintain a specific version tag and integrity hash.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated

crossorigin="anonymous"
/>
<script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the next line there is a reference to graphiqlWithExtensions. Is this old version compatible with the new version of GraphiQL ? All other features still work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ive checked and it works as expected

Expand Down Expand Up @@ -82,8 +81,8 @@
<body>
<div id="graphiql">Loading...</div>
<script
src="https://unpkg.com/graphiql@1.5.1/graphiql.min.js"
integrity="sha384-ktvW/i3KUd0D3ub91RkvHlJmf5wWqq7/VSBpCtpRrItml9btmAZH0x8c7fEXcr3e"
src="https://unpkg.com/graphiql/graphiql.min.js"
type="application/javascript"
crossorigin="anonymous"
></script>
<script>
Expand Down
Loading