tests: capture screenshot on failure #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide tests/README.md for usage instructions, when trying to reproduce the GitHub tests inside a local VM.
Our tests/build-vm-and-test.sh script relies on presence of curl command, so ensure it's available.
We need to replace `/usr/bin/env python` with `/usr/bin/env python3` as /usr/bin/python is provided only by the python-is-python3 or python-is-python2 packages through a symlink (meant for third-party or legacy scripts, see https://wiki.debian.org/Python), though those might not be present e.g. when running in a local Debian bookworm VM.
|
Example result:
|
… fails While debugging the failing GitHub Actions (see #278), we noticed that it might serve useful to have a screenshot of the booted system available. We can capture such a screenshot via vncsnapshot. NOTE: we move the files inside `results` only if the directory as such exists in $PWD, otherwise we'd fail the build when being executed as `tests/build-vm-and-test.sh test` from inside the grml-debootstrap.git. This happens when manually reproducing the GH tests, though then `build-vm-and-test.sh` is supposed to be executed from the parent directory of the `tests` directory (being the grml-debootstrap.git checkout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mika wrote most of this, I just rebased it on top of #283
Debugging aid for #278.