Fix Holiday Stops Amend #1225
Merged
Fix Holiday Stops Amend #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewHEguardian
changed the title
michaelbjacobson
approved these changes
Oct 18, 2023
|
Seen on PROD (merged by @andrewHEguardian 13 minutes and 56 seconds ago) Please check your changes! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fix amending an existing holiday stop - this was not checking the correct value and therefore calling the api with a
POSTinstead of aPATCHrequest.Fix a secondary bug when amending a non-confirmed holiday stop. The wrong dates were being set when this button was clicked, which made the holiday stop to amend appear as an existing suspension. (See image below.) This PR removes the second Amend button.
How to test
With a newspaper delivery product, click Manage suspensions, click "Amend", pick dates, click "Confirm", see loading message "Amending...", do not see error.
How can we measure success?
Have we considered potential risks?
Images
Before
Bug after pressing "Amend" on review page, the existing suspension should not appear as that is what is being amended
After
Accessibility