Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear Up Scala Warnings #6383

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Clear Up Scala Warnings #6383

wants to merge 14 commits into from

Conversation

rupertbates
Copy link
Member

@rupertbates rupertbates commented Oct 7, 2024

What are you doing in this PR?

We have built up quite a lot of warnings in our code base over time, this PR aims to remove as many of those as possible without major code changes. Changes made are:

  • Add ScalaFix plugin into the project, this does automated fixes of a number of common code issues
  • Add explicit types to public members and all implicits (this is the vast majority of the changes)
  • Remove redundant braces

Tested successfully on CODE

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Size Change: 0 B

Total Size: 2.32 MB

ℹ️ View Unchanged
Filename Size
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 114 kB
./public/compiled-assets/javascripts/[countryGroupId]/router.js 260 kB
./public/compiled-assets/javascripts/ausMomentMap.js 109 kB
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 244 kB
./public/compiled-assets/javascripts/downForMaintenancePage.js 71.4 kB
./public/compiled-assets/javascripts/error404Page.js 71.4 kB
./public/compiled-assets/javascripts/error500Page.js 71.3 kB
./public/compiled-assets/javascripts/favicons.js 617 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 198 kB
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.8 kB
./public/compiled-assets/javascripts/payPalErrorPage.js 69.8 kB
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B
./public/compiled-assets/javascripts/promotionTerms.js 74.4 kB
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 73.5 kB
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 128 kB
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 313 kB
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 195 kB
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 87.9 kB
./public/compiled-assets/webpack/136.js 2.17 kB
./public/compiled-assets/webpack/187.js 21.5 kB
./public/compiled-assets/webpack/27.js 22.6 kB
./public/compiled-assets/webpack/344.js 2.04 kB
./public/compiled-assets/webpack/706.js 107 kB

compressed-size-action

…s the 'SubscriptionsTest > should return form if user is signed in' test to fail
@rupertbates rupertbates changed the title Warnings Clear Up Scala Warnings Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant