Code

Clear Up Scala Warnings#6383

Code

Open

rupertbates wants to merge 14 commits intomainguardian/support-frontend:mainfrom warningsguardian/support-frontend:warningsCopy head branch name to clipboard

+1,418-1,256

Commits

Commits on Oct 7, 2024

• Get rid of warnings

  rupertbates

  committed
  4a5534a

  Copy full SHA for 4a5534a

• For some reason adding a type annotation to an implicit encoder causes the 'SubscriptionsTest > should return form if user is signed in' test to fail

  rupertbates

  committed
  6aa9be5

  Copy full SHA for 6aa9be5

• Test failure was down to circe full generic encoding

  rupertbates

  committed
  323b622

  Copy full SHA for 323b622

• Add scalafix to the project

  rupertbates

  committed
  da70405

  Copy full SHA for da70405

• Can't change getAllSettings just yet

  rupertbates

  committed
  9b37020

  Copy full SHA for 9b37020

• Type signatures on implicits

  rupertbates

  committed
  ba052fe

  Copy full SHA for ba052fe

• Type signatures on public members

  rupertbates

  committed
  cf74159

  Copy full SHA for cf74159

• Type signatures on ALL public members

  rupertbates

  committed
  4e81d4d

  Copy full SHA for 4e81d4d

• Fix tests

  rupertbates

  committed
  5c39f3e

  Copy full SHA for 5c39f3e

Commits on Oct 8, 2024

• countTries can be private

  rupertbates

  committed
  a2d55bf

  Copy full SHA for a2d55bf

• Remove redundant braces

  rupertbates

  committed
  d5c90fa

  Copy full SHA for d5c90fa

• Use circe semiAuto generic encoding

  rupertbates

  committed
  6f998fb

  Copy full SHA for 6f998fb

Commits on Oct 10, 2024

• Revert circe changes

  rupertbates

  committed
  6360446

  Copy full SHA for 6360446

• Merge branch 'main' into warnings

  rupertbates

  authored
  5978dc2

  Copy full SHA for 5978dc2