Update util.py #379
Merged
Update util.py #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #378 |
If the parameter is a float **or an int** assign the parameter value. Otherwise parse it.
Added type check for int, float, or str and raise a value error if none of the above
coercing `param_value` `int` to `float` allows unit tests to pass on the pyciemss side.
Added param_key and type of the param_value in the ValueError message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the parameter is a float or an int assign the parameter value. Should also put a check to see if the value is a string before passing the value to
safe_parse, and raise an error if it isn't.