Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update util.py #379

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Update util.py #379

merged 5 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Update util.py 

    If the parameter is a float **or an int** assign the parameter value. Otherwise parse it.
    @djinnome @bgyori
    djinnome authored and bgyori committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    45ee6be View commit details
    Browse the repository at this point in the history

  2. Update util.py 

    Added type check for int, float, or str and raise a value error if none of the above
    @djinnome @bgyori
    djinnome authored and bgyori committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b2c27b6 View commit details
    Browse the repository at this point in the history

  3. Update util.py 

    coercing `param_value` `int` to `float` allows unit tests to pass on the pyciemss side.
    @djinnome @bgyori
    djinnome authored and bgyori committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8220f99 View commit details
    Browse the repository at this point in the history

  4. Update util.py 

    Added param_key and type of the param_value in the ValueError message
    @djinnome @bgyori
    djinnome authored and bgyori committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    29c34e5 View commit details
    Browse the repository at this point in the history

  5. Simplify message

    @bgyori
    bgyori committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c5642ac View commit details
    Browse the repository at this point in the history