Skip to content

Conversation

@myronchen-git
Copy link
Member

@myronchen-git myronchen-git commented Oct 22, 2025

Fixes #7937

What changes did you make?

  • Added GitHub icon and empty LinkedIn link to the wins overlay HTML.
  • Updated the updateOverlay function in wins.js to attach href and aria-label attributes to and hide/show the GitHub icons, as well as have the code for the LinkedIn icon utilize the new anchor element in the HTML.
  • Explicitly set the GitHub and LinkedIn icon sizes in the wins page SCSS.

Why did you make the changes (we will use this info to test)?

  • Since the icons are now being used from _includes\svg\, the JavaScript code in assets/js/wins.js could not access the _includes folder. The workaround is to use the include tag from Jekyll in the HTML.
  • The aria-label needed to be added to the GitHub icon to make it WCAG compliant.
  • The icon sizes needed to be set in the CSS, as the former sizes no longer applied.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website, but verify this.

@myronchen-git myronchen-git added this to the x. Technical debt milestone Oct 22, 2025
@myronchen-git myronchen-git added the role: front end Tasks for front end developers label Oct 22, 2025
@myronchen-git myronchen-git added Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Oct 22, 2025
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b myronchen-git-use-different-github-svg-for-wins-overlay-7937 gh-pages
git pull https://github.com/myronchen-git/website.git use-different-github-svg-for-wins-overlay-7937

@kdaca19xx kdaca19xx self-requested a review October 26, 2025 17:14
@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 10/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Projects

Status: PR Needs review

Development

Successfully merging this pull request may close these issues.

Update wins.js so the Wins overlay uses icon-github.svg

2 participants