Skip to content

Update Wins overlay to use different SVG #8378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Update Wins overlay to use different SVG #8378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion _includes/wins-page/wins-overlay.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,14 @@
<div class="wins-card-top-right">
<div class="wins-card-title project-card-inner">
<span id="overlay-name" class="wins-card-name">Blank</span>
<span id="overlay-icons" class="wins-card-icons" alt=""></span>
<span id="overlay-icons" class="wins-card-icons" alt="">
<a target="_blank" class="wins-card-linkedin-icon"></a>
<a target="_blank" class="wins-card-github-icon" style="color:black">
<div role="img" class="github-icon">
{% include svg/icon-github.svg %}
</div>
</a>
</span>
</div>
<div id="overlay-teams" class="project-inner wins-card-team">Team(s): Blank</div>
<div id="overlay-roles" class="project-inner wins-card-team">Role(s): Blank</div>
Expand Down
12 changes: 10 additions & 2 deletions _sass/components/_wins-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,16 @@
}
}
}


#overlay-icons {
.linkedin-icon, .github-icon {
height: 32px;
width: 32px;
}
.linkedin-icon > svg, .github-icon > svg {
height: 100%;
width: 100%;
}
}
}

//mobile see more
Expand Down
33 changes: 25 additions & 8 deletions assets/js/wins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,14 +498,31 @@ function changeSeeMoreBtn(x) {
const bigQuoteImg = document.querySelector('.wins-card-big-quote');
bigQuoteImg.alt = "Quote from " + data[i][name];

const overlayIcons = document.querySelector('#overlay-icons');
overlayIcons.textContent = "";

if (data[i][linkedin_url].length > 0) {
makeIcon(data[i][linkedin_url], overlayIcons, 'linkedin-icon', '/assets/images/wins-page/icon-linkedin-small.svg', 'LinkedIn profile for ' + data[i][name]);
} if (data[i][github_url].length > 0) {
makeIcon(data[i][github_url], overlayIcons, 'github-icon', '/assets/images/wins-page/icon-github-small.svg', 'GitHub profile for ' + data[i][name]);
}
const overlayIcons = document.querySelector('#overlay-icons');
overlayIcons.querySelector('.wins-card-linkedin-icon').textContent = '';

if (data[i][linkedin_url].length > 0) {
makeIcon(
data[i][linkedin_url],
overlayIcons.querySelector('.wins-card-linkedin-icon'),
'linkedin-icon',
'/assets/images/wins-page/icon-linkedin-small.svg',
'LinkedIn profile for ' + data[i][name]
);
}

const winsCardGithubIcon = overlayIcons.querySelector('.wins-card-github-icon');

if (data[i][github_url].length > 0) {
winsCardGithubIcon.href = data[i][github_url];
winsCardGithubIcon.removeAttribute('hidden');
winsCardGithubIcon.querySelector('div.github-icon').setAttribute(
'aria-label',
'GitHub profile for ' + data[i][name]
);
} else {
winsCardGithubIcon.setAttribute('hidden', 'true');
}

const overlayName = document.querySelector('#overlay-name');
overlayName.textContent = data[i][name];
Expand Down