Fix: do not use lists as defaults in function definitions#147
Open
NodeJSmith wants to merge 1 commit intohammem:mainfrom
Open
Fix: do not use lists as defaults in function definitions#147NodeJSmith wants to merge 1 commit intohammem:mainfrom
NodeJSmith wants to merge 1 commit intohammem:mainfrom
Conversation
keithah
added a commit
to keithah/monarchmoney-enhanced
that referenced
this pull request
Sep 2, 2025
- Fix get_transactions() mutable default arguments bug (hammem#147) - Add is_credit parameter for filtering credit/debit transactions - Add abs_amount_range parameter for filtering by amount ranges - Update CHANGELOG with references to original PRs Fixes from hammem/monarchmoney repository: - PR hammem#147: hammem#147 - PR hammem#148: hammem#148 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
keithah
added a commit
to keithah/monarchmoney-enhanced
that referenced
this pull request
Sep 3, 2025
- Fix get_transactions() mutable default arguments bug (hammem#147) - Add is_credit parameter for filtering credit/debit transactions - Add abs_amount_range parameter for filtering by amount ranges - Update CHANGELOG with references to original PRs Fixes from hammem/monarchmoney repository: - PR hammem#147: hammem#147 - PR hammem#148: hammem#148 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update get_transactions to set
category_ids,account_ids, andtag_idsto beNoneinstead of an empty list, as these are only evaluated once when the function is defined, meaning that the list would be shared across all instances of the call.It doesn't appear that this is causing any issues yet but it seems better to be proactive.