Skip to content

Fix: do not use lists as defaults in function definitions #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NodeJSmith wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: do not use lists as defaults in function definitions #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions monarchmoney/monarchmoney.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,9 +1440,9 @@ async def get_transactions(
start_date: Optional[str] = None,
end_date: Optional[str] = None,
search: str = "",
category_ids: List[str] = [],
account_ids: List[str] = [],
tag_ids: List[str] = [],
category_ids: Optional[List[str]] = None,
account_ids: Optional[List[str]] = None,
tag_ids: Optional[List[str]] = None,
has_attachments: Optional[bool] = None,
has_notes: Optional[bool] = None,
hidden_from_reports: Optional[bool] = None,
Expand Down Expand Up @@ -1471,6 +1471,10 @@ async def get_transactions(
:param synced_from_institution: a bool to filter for whether the transactions were synced from an institution.
"""

category_ids = category_ids or []
account_ids = account_ids or []
tag_ids = tag_ids or []

query = gql(
"""
query GetTransactionsList($offset: Int, $limit: Int, $filters: TransactionFilterInput, $orderBy: TransactionOrdering) {
Expand Down