remove partners list and map #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clare-stanton
requested review from
rebeccacremona
and removed request for
a team
no longer needed without partner list
hopefully deleting whole file
not necessary without partners map / list
not necessary without partner list / map
Codecov Report
@@ Coverage Diff @@
## develop #3362 +/- ##
===========================================
- Coverage 70.01% 69.79% -0.23%
===========================================
Files 52 50 -2
Lines 6993 6945 -48
===========================================
- Hits 4896 4847 -49
- Misses 2097 2098 +1
|
rebeccacremona
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Hooray, Clare 🎉 🎉 🎉 !
What a fun way to end the week.
I think this is good to go! We can think about whether to delete the database column, clean up the CSS etc. some other time :-)
We have never removed a JS bundle from webpack config before, so we'll just have to see how that plays out during deployment 😂
|
Ah, thank you, tests, for failing: @clare-stanton the landing page also has a registrar logo carousel, we did not remember. I will remove it too.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing partners list and map from About page because it is outdated and would be visually overcrowded and not useful if it we were to fully update it.