-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose node account id in relay logging of failed transactions #3292
feat: expose node account id in relay logging of failed transactions #3292
Conversation
Signed-off-by: nikolay <[email protected]>
Test Results 18 files - 4 235 suites - 60 29m 54s ⏱️ - 6m 22s Results for commit d669b9b. ± Comparison against base commit b55ca6b. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
Please open a ticket to move logicinto SDKError & unpdate existing error logs later
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
- Coverage 78.88% 77.82% -1.06%
==========================================
Files 48 66 +18
Lines 3608 4474 +866
Branches 841 1005 +164
==========================================
+ Hits 2846 3482 +636
- Misses 423 617 +194
- Partials 339 375 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
The Relay server currently lacks visibility into which node account ID a transaction was submitted to when it fails due to an SDK error. With the recent update to the
hedera-sdk-js
, the error object now includes the node account ID for failed transactions.This new capability in the Relay's logging system is expected to improve troubleshooting and provide better insights into node-specific transaction failures.
Solution:
Update the Relay server's logging system to extract and log the node account ID from the error object provided by the SDK
Related issue(s):
Fixes #3278
Notes for reviewer:
Checklist