Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144

Merged

nit: resolve PR comments

dfa1545
Select commit
Loading
Failed to load commit list.
Merged

refactor: adapt StatsSigningTestingTool to work with Bytes wrapper for transactions #17144

nit: resolve PR comments
dfa1545
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 14, 2025 in 0s

67.77% (+0.18%) compared to f26286a

View this Pull Request on Codecov

67.77% (+0.18%) compared to f26286a

Details

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (f26286a) to head (dfa1545).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...emo/stats/signing/StatsSigningTestingToolMain.java 53.84% 6 Missing ⚠️
...mo/stats/signing/StatsSigningTestingToolState.java 83.33% 3 Missing and 1 partial ⚠️
...swirlds/demo/stats/signing/SttTransactionPool.java 0.00% 2 Missing ⚠️
...m/swirlds/demo/stats/signing/TransactionCodec.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #17144      +/-   ##
============================================
+ Coverage     67.58%   67.77%   +0.18%     
- Complexity    22142    22204      +62     
============================================
  Files          2588     2588              
  Lines         96701    96730      +29     
  Branches      10099    10103       +4     
============================================
+ Hits          65359    65560     +201     
+ Misses        27604    27416     -188     
- Partials       3738     3754      +16     
Files with missing lines Coverage Δ
...m/swirlds/demo/stats/signing/TransactionCodec.java 34.56% <66.66%> (+34.56%) ⬆️
...swirlds/demo/stats/signing/SttTransactionPool.java 1.53% <0.00%> (+1.53%) ⬆️
...mo/stats/signing/StatsSigningTestingToolState.java 47.12% <83.33%> (+47.12%) ⬆️
...emo/stats/signing/StatsSigningTestingToolMain.java 30.43% <53.84%> (+30.43%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph