-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak "request review" design #274
Conversation
|
||
{{! <FlightIcon @size="16" @name="globe" /> }} | ||
</div> | ||
Your doc will appear on Hermes and Google Group emails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your doc will appear on Hermes and Google Group emails. | |
Your document will appear in Hermes and Google Workspace search. |
|
||
<FlightIcon @size="16" @name="globe-private" /> | ||
</div> | ||
Published docs cannot be deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Published docs cannot be deleted. | |
Published documents cannot be deleted but can archived. |
<FlightIcon @size="16" @name="at-sign" /> | ||
</div> | ||
Approvers and people subscribed to | ||
{{@document.product}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{@document.product}} | |
"{{@document.product}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good, I think this messaging will be clearer for users.
Tweaks the "request review" elements to make the process clearer.
Some users mistake "request[ing a] review," which publishes the doc and triggers email notifications, for a lightweight "get eyes on this" type of action. The proposed design moves the idea of "publishing" to the forefront, and calls out, in explicit terms what the action does.
Current
Proposed