Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak "request review" design #274

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Tweak "request review" design #274

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd994d3
Tweak "request review" design
jeffdaley Jul 26, 2023
85b6db0
Copy tweaks
jeffdaley Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 45 additions & 11 deletions web/app/components/document/sidebar.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@
{{#if this.isOwner}}
<div class="flex items-start px-3 gap-2">
<Hds::Button
@text="Request Review"
@text="Publish for review..."
@size="medium"
@color="primary"
class="w-full"
Expand Down Expand Up @@ -547,13 +547,12 @@

{{#if this.requestReviewModalIsActive}}
<Document::Modal
@headerText="Request review"
@headerText="Publish for review"
@errorTitle="Error requesting review"
@close={{this.closeRequestReviewModal}}
@task={{perform this.requestReview}}
@taskButtonText="Request review"
@taskButtonLoadingText="Requesting review..."
@taskButtonIcon="test"
@taskButtonText="Publish doc"
@taskButtonLoadingText="Publishing..."
@hideFooterWhileSaving={{true}}
@taskButtonIsDisabled={{and
(not this.docTypeCheckboxValue)
Expand All @@ -564,7 +563,7 @@
{{#if M.taskIsRunning}}
<div class="grid place-items-center pt-1 pb-12">
<div class="text-center">
<FlightIcon @name="loading" @size={{24}} class="mb-5" />
<FlightIcon @name="loading" @size="24" class="mb-5" />
<h2>Submitting for review...</h2>
<p class="text-body-300 mb-2">This usually takes about a minute.</p>
<span
Expand All @@ -581,10 +580,44 @@
</div>
</div>
{{else}}
<p class="mb-4 pr-16 text-body-300 text-color-foreground-primary">
This will publish your document company-wide, and anyone you request
below will receive a notification to review.
</p>
<ul class="mb-6 space-y-1 text-body-300">
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>
<FlightIcon @size="16" @name="at-sign" />
</div>
Approvers and people subscribed to
{{@document.product}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{@document.product}}
"{{@document.product}}"

will be notified.
</li>
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>
<FlightIcon @size="16" @name="radio" />

{{! <FlightIcon @size="16" @name="globe" /> }}
</div>
Your doc will appear on Hermes and Google Group emails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Your doc will appear on Hermes and Google Group emails.
Your document will appear in Hermes and Google Workspace search.

</li>
<li class="flex items-center">
<div
class="mr-2.5 inline-flex rounded-full text-color-palette-neutral-400"
>

<FlightIcon @size="16" @name="globe-private" />
</div>
Published docs cannot be deleted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Published docs cannot be deleted.
Published documents cannot be deleted but can archived.

</li>
</ul>
{{!-- <p class="mb-4 pr-16 text-body-300 text-color-foreground-primary">
This will publish your document company-wide.
<br />Anyone subscribed to
{{@document.product}}
will be notified, along with the approvers below.
</p> --}}

<Hds::Form::Field @layout="vertical" as |F|>
<F.Control>
<Inputs::PeopleSelect
Expand All @@ -595,8 +628,9 @@
class="mb-0"
/>
</F.Control>
<F.Label>Add approvers</F.Label>
<F.Label>Approvers</F.Label>
</Hds::Form::Field>

{{#if @docType.checks.length}}
{{! For now, we only support one check }}
{{#each (take 1 @docType.checks) as |check|}}
Expand Down