New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spacing of bash scripts #21760

Merged

jm96441n merged 3 commits into main from fix-changelog-script

Sep 19, 2024

Member

jm96441n commented Sep 17, 2024

Description

Fixed spacing of variable declarations, fixed shellcheck violations

Testing & Reproduction steps

Links

PR Checklist

updated test coverage
external facing docs updated
appropriate backport labels added
not a security concern


          fix spacing of bash scripts

1e97297

jm96441n added pr/no-docs backport/all labels


          shellcheck all the things

b7053f5

jm96441n added the pr/no-changelog label

missylbytes reviewed

View reviewed changes

build-support/scripts/gen-changelog.sh Outdated Show resolved Hide resolved


          cat filename rather than concatenating pr number

a391f2f

missylbytes approved these changes

View reviewed changes

jm96441n merged commit 2d19cd5 into main

94 checks passed

jm96441n deleted the fix-changelog-script branch

September 19, 2024 18:09

hc-github-team-consul-core added backport/1.19 backport/1.20 backport/ent/1.17 backport/ent/1.15 backport/ent/1.18 labels

This was referenced Sep 19, 2024

Backport of fix spacing of bash scripts into release/1.19.x #21768

Merged

Backport of fix spacing of bash scripts into release/1.20.x #21769

Merged

Collaborator

hc-github-team-consul-core commented Sep 20, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

3 similar comments

Collaborator

hc-github-team-consul-core commented Sep 21, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Sep 22, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Sep 23, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Sep 24, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

This was referenced Sep 24, 2024

Backport of fix spacing of bash scripts into release/1.20.x dhiaayachi/consul#15

Open

Backport of fix spacing of bash scripts into release/1.19.x dhiaayachi/consul#16

Open

Collaborator

hc-github-team-consul-core commented Sep 25, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

This was referenced Sep 25, 2024

Backport of fix spacing of bash scripts into release/1.20.x dhiaayachi/consul#35

Open

Backport of fix spacing of bash scripts into release/1.19.x dhiaayachi/consul#36

Open

Collaborator

hc-github-team-consul-core commented Sep 26, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments

Collaborator

hc-github-team-consul-core commented Sep 27, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Sep 28, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Sep 29, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

16 similar comments

Collaborator

hc-github-team-consul-core commented Sep 30, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 1, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 2, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 3, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 4, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 5, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 6, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 7, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 8, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 9, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 10, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 11, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 12, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 13, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 14, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Collaborator

hc-github-team-consul-core commented Oct 14, 2024

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

nathancoleman removed the backport/ent/1.15 label

jm96441n removed the backport/all label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.17 backport/ent/1.18 backport/1.19 backport/1.20 pr/no-changelog pr/no-docs