Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spacing of bash scripts #21760

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix spacing of bash scripts #21760

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e97297
fix spacing of bash scripts
jm96441n Sep 17, 2024
b7053f5
shellcheck all the things
jm96441n Sep 17, 2024
a391f2f
cat filename rather than concatenating pr number
jm96441n Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions build-support/scripts/gen-changelog.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,28 @@ set -eo pipefail

pr_number=$(gh pr list -H "$(git rev-parse --abbrev-ref HEAD)" -q ".[0].number" --json "number")

if [ -z "$pr_number" ]; then
echo "Error: Could not find PR number."
exit 1
fi

# check if this changelog is referencing an enterprise change
curdir=$(pwd)

filename = ".changelog/$pr_number.txt"
filename=".changelog/$pr_number.txt"
if [[ ! $curdir == *"enterprise"* ]]; then
is_enterprise = "n"
read -p "Is this an enterprise PR? (y/n): " is_enterprise
is_enterprise="n"
read -rp "Is this an enterprise PR? (y/n): " is_enterprise

if [[ $is_enterprise == "y" ]]; then
filename = ".changelog/_$pr_number.txt"
filename=".changelog/_$pr_number.txt"
fi
else
filename = ".changelog/_$pr_number.txt"
filename=".changelog/_$pr_number.txt"
fi

# create a new changelog file
touch $filename
touch "$filename"

echo "Created a new changelog file for PR $pr_number."

Expand All @@ -35,7 +40,7 @@ echo "4. deprecation"
echo "5. bug"

if [ -z "$1" ]; then
read -p "Enter your choice: " choice
read -rp "Enter your choice: " choice
else
choice=$1
fi
Expand Down Expand Up @@ -66,8 +71,10 @@ esac

msg=""

read -ep $'Please enter the changelog message:\n' msg
read -erp $'Please enter the changelog message:\n' msg

echo -e "\`\`\`release-note:$type\n$msg\n\`\`\`" >>"$filename"

cat .changelog/$pr_number.txt
echo -e "\nChangelog added to $filename. Contents:\n"

cat "$filename"
Loading