Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spacing of bash scripts #21760

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix spacing of bash scripts #21760

merged 3 commits into from
Sep 19, 2024

Conversation

jm96441n
Copy link
Member

Description

Fixed spacing of variable declarations, fixed shellcheck violations

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jm96441n jm96441n added pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. backport/all Apply backports for all active releases per .release/versions.hcl labels Sep 17, 2024
@jm96441n jm96441n added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 17, 2024
@jm96441n jm96441n merged commit 2d19cd5 into main Sep 19, 2024
94 checks passed
@jm96441n jm96441n deleted the fix-changelog-script branch September 19, 2024 18:09
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 19, 2024
This was referenced Sep 19, 2024
Merged
Merged
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

3 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15,1.17,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

This was referenced Sep 24, 2024
Open
Open
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

This was referenced Sep 25, 2024
Open
Open
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

2 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @jm96441n! a backport is missing for this PR [21760] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missylbytes missylbytes missylbytes approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 Changes are backported to 1.19 backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jm96441n @hc-github-team-consul-core @missylbytes