Fix TestDNS_ServiceLookup_ARecordLimits so that it only creates test agents the minimal amount of time #21608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the section duplicate..
…thern than infer it in checkDNSService
…guration which is based on the a_record_limit.
jmurret
added
pr/no-changelog
4 tasks
zalimeni
approved these changes
Aug 15, 2024
…gents the minimal amount of time. (#21609) Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time
4 tasks
philrenaud
pushed a commit
that referenced
this pull request
Sep 12, 2024
…agents the minimal amount of time (#21608) * get rid of unused column * get rid of duplicate section now that deletion of unused column makes the section duplicate.. * explicit set protocol rathern than infer it in checkDNSService * explicit have attribute for whether to set EDNS0 in the test cases rathern than infer it in checkDNSService * now modify so that test agents are only created for each unique configuration which is based on the a_record_limit. * Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time. (#21609) Fix TestDNS_ServiceLookup_AnswerLimits so that it only creates test agents the minimal amount of time
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestDNS_ServiceLookup_ARecordLimitsis one of our longest running tests.It's average runtime in CI over the last 3 months is 1min 45 secs.
Locally on a mac M1, it performs in 1 min 11 seconds:
The reason why is that for every test case it spawns a new TestAgent. This is 112 test agents getting spawned, taking up ports, file descriptors, etc.
Re-arranging this test so that test agents are only created when the agent config changes, reduces it to 7 Test Agents getting created. (There was also a category of tests that could be removed as duplicates that removed 28 of the test agent).
This is the test results locally now that finish in 10 secs:
Testing & Reproduction steps
Links
PR Checklist