[RFC Don't Merge] Gophercloud resync #4211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2016 16:55
- github.com/rackspace/gophercloud is now feature frozen and is replaced by the repo at github.com/gophercloud/gophercloud - Remove old vendored files for rackspace version of gophercloud - Add new vendored version of gophercloud from new repo - Fix various API changes in gophercloud - Remove support for RackSpace API keys (not supported in new gophercloud repo)
rickard-von-essen
added
builder/openstack
enhancement
pr/needs-review
stage/thinking
|
Awesome! I'll try and find some time for testing this. |
|
I've had a deeper look into the API key authentication. It's a RackSpace-specific feature, and they have their own nova client build (which includes the required auth extension). The good part is this can be run-time discovered and gophercloud could try it should the extension be present, but it would require changes to gophercloud to implement. (I note Rackspace's nova client treats password as possibly an API key, so we may want do the same thing, assuming gophercloud is modified to accept this model..) |
|
Here's how terraform did the switch-over hashicorp/terraform#9407 I'll implement that as part of #4113 |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shifts the Gophercloud OpenStack SDK out of the Rackspace repositories to a repo maintained specifically for Gophercloud.
The old repo is now closed to new features (see rackspace/gophercloud#612)
Between the two, there has been a few changes:
The PR removes the old vendored version of the rackspace/gophercloud repo and vendors the new repo and brings it up to date. Adjustments to the OpenStack builders to accomdate the newer version is also included.
THIS IS UNTESTED. DO NOT MERGE. This request is more of an RFC about whether this should be done at all. This would form the first step of adding new features to the OpenStack builder (eg, block device mapping support).