Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-5370 Add Flexible Deployment Options #224

Merged
merged 25 commits into from
Sep 21, 2023
Merged

TF-5370 Add Flexible Deployment Options #224

merged 25 commits into from
Sep 21, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Sep 12, 2023

Background

relates to: terraform-random-tfe-utility
Jira:

Relates: https://github.com/hashicorp/ptfedev-infra/pull/526

  • This will stay in PR until the terraform-random-tfe-utility merges.
  • Change modules branch references in this repo to main
  • Run ptfe-replicated Azure tests on this branch (done here)

How Has This Been Tested

In a follow up PR I will create a workflow that adds another test suite for FDO, but for now, I'm simply changing the is_legacy_deployment default to true or false depending on which I'm testing.

Testing the following:

  • standalone-external in legacy mode (link)
  • standalone-mounted-disk in legacy mode (link)
  • public-active-active in legacy mode (link)
  • private-active-active in legacy mode (link)
  • private-tcp-active-active in legacy mode (link)
  • standalone-external in FDO mode (link)
  • standalone-mounted-disk in FDO mode (link)
  • public-active-active in FDO mode (link)
  • private-active-active in FDO mode (link)
  • private-tcp-active-active in FDO mode (link)

Test Configuration

  • Terraform Version: latest
  • Any additional relevant variables: is_legacy_deployment = false

@anniehedgpeth anniehedgpeth changed the title Ah/tf 5370 TF-5370 Add Flexible Deployment Options Sep 12, 2023
@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 13, 2023

/test private-tcp-active-active destroy=false
is_legacy_deployment=false

✅ Terraform Azure Private TCP Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 13, 2023

/destroy private-tcp-active-active

✅ Terraform Azure Private TCP Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 13, 2023

/test standalone-mounted-disk
is_legacy_deployment=false

❌ Terraform Azure Standalone Mounted Disk Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ❌ Terraform Apply

  • ❌ Run k6 Smoke Test

  • ❌ Terraform Destroy

✅ Terraform Azure Standalone Mounted Disk Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 13, 2023

/test standalone-external
is_legacy_deployment=false

❌ Terraform Azure Standalone External Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ❌ Terraform Apply

  • ❌ Run k6 Smoke Test

  • ❌ Terraform Destroy

❌ Terraform Azure Standalone External Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 13, 2023

/test public-active-active
is_legacy_deployment=false

✅ Terraform Azure Public Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 14, 2023

/destroy standalone-external

✅ Terraform Azure Standalone External Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/destroy private-active-active

✅ Terraform Azure Private Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/test private-active-active destroy=false
is_legacy_deployment=false

✅ Terraform Azure Private Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/destroy private-active-active

✅ Terraform Azure Private Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/test all
var.is_legacy_deployment = true

❌ Terraform Azure Standalone External Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ❌ Terraform Destroy

✅ Terraform Azure Standalone Mounted Disk Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Private TCP Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test <-- false positive- no tf runs were applied

  • ✅ Terraform Destroy

✅ Terraform Azure Public Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

  • ✅ Terraform Destroy

✅ Terraform Azure Private Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test <-- false positive- no tf runs were applied

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/destroy standalone-external

✅ Terraform Azure Standalone External Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/test private-tcp-active-active destroy=false
var.is_legacy_deployment = true

  • pinning the load_balancer_waf_rule_set_version to 3.1 for legacy

❌ Terraform Azure Private TCP Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ❌ Run k6 Smoke Test

✅ Terraform Azure Private TCP Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 15, 2023

/test private-active-active destroy=false
var.is_legacy_deployment = true

✅ Terraform Azure Private Active/Active Test Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Validate

  • ✅ Terraform Apply

  • ✅ Run k6 Smoke Test

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 18, 2023

/destroy private-active-active

✅ Terraform Azure Private Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth
Copy link
Contributor Author

anniehedgpeth commented Sep 18, 2023

/destroy private-tcp-active-active

✅ Terraform Azure Private TCP Active/Active Destruction Report

🔗 Action Summary Page

  • ✅ Terraform Init

  • ✅ Terraform Destroy

@anniehedgpeth anniehedgpeth marked this pull request as ready for review September 21, 2023 17:45
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner September 21, 2023 17:45
theoskolnik
theoskolnik previously approved these changes Sep 21, 2023
Copy link
Contributor

@theoskolnik theoskolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust the tests!

@anniehedgpeth anniehedgpeth merged commit 795e1ce into main Sep 21, 2023
2 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/tf-5370 branch September 21, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants