Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ah/tf 5370 #118

Merged
merged 40 commits into from
Sep 21, 2023
Merged

Ah/tf 5370 #118

merged 40 commits into from
Sep 21, 2023

Conversation

anniehedgpeth
Copy link
Contributor

@anniehedgpeth anniehedgpeth commented Sep 19, 2023 •
edited
Loading

anniehedgpeth added 25 commits September 5, 2023 11:04
add docker config module and fdo deployment
13b709c
beautify variables
5d9e820
types for variables
548c0f0
remove defaults in docker compose vars
f2f7e12
make tls_version empty string if null
6b2c974
conditional for user data locals
4efa80d
null defaults for cloud storage
1ead2d0
fix tls_version conditional
5fe5a53
fix conditionals
9f8d911
Merge branch 'main' into ah/tf-5370
d06b1e6
remove haproxy
2d81843
create separate tfe_init_legacy module
f3f08a0
clean up after new module
35b60c0
escape dollar sign
df9803e
add copyright headers and alphabetize vars
75c6e60
fix extra_no_proxy
2cdcd63
add docker install for rhel to init
1ca9854
use centos pkg for real this time
17208a4
escape char
cdd615c
always export host_ip
efc7734
remove extra /
7867937
add port 6380 for redis tls
9e097fb
remove type on yaml
b1272db
fix redis tls conditional
5813965
add azure legacy tests; old tests default to FDO
0f7b39a
@anniehedgpeth anniehedgpeth mentioned this pull request Sep 19, 2023
Merged
13 tasks
@anniehedgpeth anniehedgpeth mentioned this pull request Sep 20, 2023
Merged
3 tasks
This was referenced Sep 21, 2023
Closed
Merged
@anniehedgpeth anniehedgpeth marked this pull request as ready for review September 21, 2023 17:52
@anniehedgpeth anniehedgpeth requested a review from a team as a code owner September 21, 2023 17:52
theoskolnik
theoskolnik approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@theoskolnik theoskolnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modules seem fine and I trust the tests more than my ability to read through all of this -- the new modules all look familiar though. I'd like to look through this over zoom with you at some point for the main driving GHA.

.github/workflows/aws-tests.yml Outdated Show resolved Hide resolved
modules/tfe_init/README.md Outdated Show resolved Hide resolved
@anniehedgpeth anniehedgpeth merged commit 1b03e37 into main Sep 21, 2023
2 checks passed
@anniehedgpeth anniehedgpeth deleted the ah/tf-5370 branch September 21, 2023 20:29
arnvid pushed a commit to arnvid/terraform-random-tfe-utility that referenced this pull request Nov 2, 2023
@anniehedgpeth
Ah/tf 5370 (hashicorp#118)
a529d5c 
* add docker config module and fdo deployment
* add common destroy workflow
* add reusable aws test workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoskolnik theoskolnik theoskolnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anniehedgpeth @theoskolnik